Skip to content

CLN: cleanup, deduplicate plotting/test_frame #37714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 9, 2020
Merged

CLN: cleanup, deduplicate plotting/test_frame #37714

merged 3 commits into from
Nov 9, 2020

Conversation

ivanovmg
Copy link
Member

@ivanovmg ivanovmg commented Nov 9, 2020

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry
  1. Make more reasonable var names
  2. Get rid of one test in favor of parametrization in another one

charlesdong1991
charlesdong1991 approved these changes Nov 9, 2020
View reviewed changes
Copy link
Member

@charlesdong1991 charlesdong1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice

@charlesdong1991 charlesdong1991 added Clean Testing pandas testing functions or related to the test suite Visualization plotting labels Nov 9, 2020
@charlesdong1991 charlesdong1991 added this to the 1.2 milestone Nov 9, 2020
@jreback jreback merged commit aab60f5 into pandas-dev:master Nov 9, 2020
@jreback
Copy link
Contributor

jreback commented Nov 9, 2020

thanks @ivanovmg very nice

@ivanovmg ivanovmg deleted the cleanup/plotting-test-frame branch November 10, 2020 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charlesdong1991 charlesdong1991 charlesdong1991 approved these changes

Assignees
No one assigned
Labels
Clean Testing pandas testing functions or related to the test suite Visualization plotting
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.
3 participants
@ivanovmg @jreback @charlesdong1991