BUG: Fix return of missing values when applying loc to single level of MultiIndex #37706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
added
Indexing
jreback
requested changes
Nov 9, 2020
| # GH: 27104 | ||
| df = DataFrame( | ||
| {"col": [1, 2, 5], "ind1": ["a", "d", np.nan], "ind2": [1, 4, 5]} | ||
| ).set_index(["ind1", "ind2"]) |
There was a problem hiding this comment.
can you also select df.loc['a'] as the first case in OP (which is working). can parameterize if easy.
There was a problem hiding this comment.
Parametrization would be ugly, because Index needs new definition. Added the test below.
There was a problem hiding this comment.
kk totally fine, i always ask, but like you did push back if its non-trivial or would make it less obvious.
jreback
approved these changes
Nov 9, 2020
|
cc @jreback green Thanks for merging master |
� Conflicts: � doc/source/whatsnew/v1.2.0.rst
� Conflicts: � doc/source/whatsnew/v1.2.0.rst
doc/source/whatsnew/v1.2.0.rst
Outdated
| @@ -466,7 +466,8 @@ Indexing | |||
| - Bug in indexing on a :class:`Series` or :class:`DataFrame` with a :class:`MultiIndex` with a level named "0" (:issue:`37194`) | |||
| - Bug in :meth:`Series.__getitem__` when using an unsigned integer array as an indexer giving incorrect results or segfaulting instead of raising ``KeyError`` (:issue:`37218`) | |||
| - Bug in :meth:`Index.where` incorrectly casting numeric values to strings (:issue:`37591`) | |||
| - Bug in :meth:`Series.loc` and :meth:`DataFrame.loc` raises when numeric label was given for object :class:`Index` although label was in :class:`Index` (:issue:`26491`) | |||
| - Bug in :meth:`DataFrame.loc` returned requested key plus missing values when ``loc`` was applied to single level from :class:`MultiIndex` (:issue:`27104`) | |||
| - Bug in :meth:`Series.loc` and :meth:`DataFrame.loc` raises when numeric label was given for object :class:`Index` although label was in :class:`Index` (:issue:`26491`)>>>>>>> master | |||
There was a problem hiding this comment.
seems there is a >>>>>>> master?
There was a problem hiding this comment.
Looks like merge went wrong. Is fixed now. Thanks
|
very nice @phofl |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffThis confused
-1representing missing values in input with the-1signaling which components to exclude from output.