Skip to content

DOC: Highlight pre-commit section #37701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 10, 2020
Merged

DOC: Highlight pre-commit section #37701

merged 2 commits into from
Nov 10, 2020

Conversation

hongshaoyang
Copy link
Contributor

@hongshaoyang
DOC: Highlight pre-commit section
d237fb3 
- Move section up one level in contributing.rst
- Point users to pre-commit in code_style.rst
@hongshaoyang hongshaoyang force-pushed the 37358-mention-precommit branch from cc647f9 to d237fb3 Compare November 8, 2020 12:38
@hongshaoyang
Copy link
Contributor Author

I noticed that https://dev.pandas.io/ is not up to date, is this intended?

it seems like this is intentional and that latest docs from master are at https://pandas.pydata.org/docs/dev/, see #37248.

@jreback jreback added the Docs label Nov 9, 2020
@jreback jreback added this to the 1.2 milestone Nov 9, 2020
@jreback
Copy link
Contributor

jreback commented Nov 9, 2020

looks fine to me. @MarcoGorelli if you can have a look see

MarcoGorelli
MarcoGorelli suggested changes Nov 9, 2020
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks, just suggesting some minor changes

@hongshaoyang
Copy link
Contributor Author

Thanks @MarcoGorelli , applied your suggestions.

@jreback
Copy link
Contributor

jreback commented Nov 10, 2020

lgtm. cc @MarcoGorelli merge when ready

@MarcoGorelli MarcoGorelli merged commit cf31d1b into pandas-dev:master Nov 10, 2020
@MarcoGorelli
Copy link
Member

Thanks @hongshaoyang

@hongshaoyang hongshaoyang deleted the 37358-mention-precommit branch November 10, 2020 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoGorelli MarcoGorelli MarcoGorelli requested changes

Assignees
No one assigned
Labels
Docs
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.

DOC mention pre-commit as a way to run (some) code checks
3 participants
@hongshaoyang @jreback @MarcoGorelli