Skip to content

DOC: test organization #37637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Nov 11, 2020
Merged

DOC: test organization #37637

merged 9 commits into from
Nov 11, 2020

Conversation

jbrockmendel
Copy link
Member

Documenting the MO behind the test organization we've been doing.

  1. I expect this is not valid rst ATM
  2. The style does not match the rest of the docs, so probably needs a re-write.

Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm small comments.


C) Is the method an indexing method?
i) Is the method ``loc``, ``iloc``, ``at``, or ``iat``?
This test likely belongs in one of:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you be a little more precise here (e.g. do we have criteria for putting in pandas/tests/indexing over the frame/series ones? (can be a TODO of course)

@@ -21,3 +21,4 @@ Development
policies
roadmap
meeting
test_writing
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe put after internals

@jreback jreback added Docs Testing pandas testing functions or related to the test suite labels Nov 8, 2020
@jreback jreback added this to the 1.2 milestone Nov 8, 2020
@jreback jreback merged commit a3d6ad8 into pandas-dev:master Nov 11, 2020
@jreback
Copy link
Contributor

jreback commented Nov 11, 2020

thanks @jbrockmendel very nice

@jbrockmendel jbrockmendel deleted the doc-testorg branch November 11, 2020 01:02
@jbrockmendel
Copy link
Member Author

i think this might have been merged prematurely, the docbuild is complaining about rst stuff i need to figure out

jorisvandenbossche added a commit that referenced this pull request Nov 11, 2020
@jorisvandenbossche
Copy link
Member

@jbrockmendel if you push your branch again, I think you should be able to reopen the PR (unless you also already deleted the branch locally), and then we can work out the failures here

jorisvandenbossche added a commit that referenced this pull request Nov 11, 2020
@jbrockmendel jbrockmendel restored the doc-testorg branch November 11, 2020 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants