Backport PR #37613 on branch 1.1.x: BUG: read-only values in cython funcs #37633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n cython funcs
simonjayhawkins
added
the
Compat
|
@simonjayhawkins whats your preferred way to move forward here? |
7 tasks
|
i would prob just close this backport (and fix the release note), but either way ok |
|
any resolution on this one (happy to just not backport as well). |
|
leave it open, I keep putting this off!, but the open issues on 1.1.5 milestone is getting less, so can't put it off much longer! |
Closed
This reverts commit 458e0ce.
|
closing for now. nothing needs to change on master as milestone and release note are 1.2 for #37613 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport PR #37613
will update milestones on PR and associated issues once this is green-ish. Will also need to update release notes on master. (move from 1.2 to 1.1.5)