ENH: named agg with multiple columns

[erfannariman]

• closes Named aggregations with multiple columns #29268
• tests added / passed
• passes black pandas
• passes git diff upstream/master -u -- "*.py" | flake8 --diff
• whatsnew entry

[jreback]

pls add tests always

in fact tests should be done before any code changes to make sure they behave properly

[erfannariman]

Thanks for the heads up @jreback , actually I was hoping to get some feedback which was the reason I pushed this as a draft while developing to get some comments. Some parts are challenging since I am not sure if I make the right decisions.

[ivanovmg]

Can you add the test based on the example in the issue #29268 where you demonstrated aggregation a.max() - b.max()?
This will be a good starting point for testing.
Then we can think of covering edge cases.

[ivanovmg]

Should probably have else clause.

else:
    raise KeyError(f"Column '{k}' does not exist!")

[erfannariman]

Yes, good point, added. Thanks.

[erfannariman]

What would you think of :

not_found = [c for c in k if c not in selected_obj.columns]
raise KeyError(f"Column(s) {', '.join(not_found)} do(es) not exist!")

[pep8speaks]

Hello @erfannariman! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-09-12 11:44:58 UTC

[erfannariman]

@jreback @ivanovmg I made some progress, but I am at the point that I need to pass the DataFrame as a obj to the aggregator instead of a Series so we can do the aggregation over the columns.

[github-actions]

This pull request is stale because it has been open for thirty days with no activity. Please update or respond to this comment if you're still interested in working on this.

[jreback]

@erfannariman status here?

[erfannariman]

@erfannariman status here?

This went stale, but is definitely one I would like very much to finish. I just think it gets quite complex on some points where I could use some guidance. Will take asap to clean up, merge master etc so it's updated.

[lithomas1]

@erfannariman Can you merge master/update? Thanks.

[simonjayhawkins]

Thanks @erfannariman for the PR. closing as stale. ping if you want to continue.

[erfannariman]

Thanks @erfannariman for the PR. closing as stale. ping if you want to continue.

Started to work on this PR again, can you re-open? Thanks @simonjayhawkins

[jreback]

this is quite old, happen to reopen if actively worked on.