TST/REF: collect tests by method #37573
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Nov 2, 2020
pandas/tests/io/test_pickle.py
Outdated
| tm.assert_series_equal(unp_series, string_series) | ||
|
|
||
|
|
||
| def _pickle_roundtrip(obj): |
There was a problem hiding this comment.
can you remove in favor of tm.round_trip_pickle
There was a problem hiding this comment.
i thought about this but held off because they're not quite the same. tm.round_trip_pickle calls pd.to_pickle whereas this calls obj.to_pickle. do we need to care about the difference?
There was a problem hiding this comment.
you are welcome to add direct pickle callas in round_trip_pickle
they are the same
except that read_pickle can read from older versions
kesmit13
pushed a commit
to kesmit13/pandas
that referenced
this pull request
Nov 2, 2020
* TST/REF: collect tests by method * use round_trip_pickle
ukarroum
pushed a commit
to ukarroum/pandas
that referenced
this pull request
Nov 2, 2020
* TST/REF: collect tests by method * use round_trip_pickle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is something of an outlier in that it collects iter/iteritems/iterrows/itertuples into a test_iteration file. I think this is a sufficiently clear grouping, akin to test_arithmetic/test_reductions/test_unary, LMK if you disagree.