Add ss02 #37559
Merged
Add ss02 #37559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Nov 2, 2020
abhishekmangla
force-pushed
the
add-ss02
branch
from
8856798 to
51425d7
Compare
|
@jreback I resolved your comments, I think this is ready for review. Test that is failing in CI is pandas/tests/test_sorting.py which passes on my machine and is unrelated to this PR. |
jreback
reviewed
Nov 9, 2020
| """ | ||
| Timestamp.strftime(format) | ||
|
|
||
| Return a string representing the given POSIX timestamp |
There was a problem hiding this comment.
can you add the link to the format strings (pointed at here: https://pandas.pydata.org/docs/reference/api/pandas.DatetimeIndex.strftime.html?highlight=strftime#pandas.DatetimeIndex.strftime)
There was a problem hiding this comment.
I have added the link
jreback
approved these changes
Nov 10, 2020
|
thanks @abhishekmangla |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SS02and check in CI #25113, closes DOC: TimeStamp.strftime() missing argument description #36745black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff