Skip to content

TYP: obj in aggregation.py #37532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 31, 2020
Merged

TYP: obj in aggregation.py #37532

merged 3 commits into from
Oct 31, 2020

Conversation

rhshadrach
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@rhshadrach rhshadrach added Apply Apply, Aggregate, Transform, Map Typing type annotations, mypy/pyright type checking labels Oct 31, 2020
@jreback
Copy link
Contributor

jreback commented Oct 31, 2020

hmm failing some ci/checks

@jreback jreback added this to the 1.2 milestone Oct 31, 2020
@jreback
Copy link
Contributor

jreback commented Oct 31, 2020

lgtm merge on green

@jreback jreback merged commit 64027e6 into pandas-dev:master Oct 31, 2020
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
@rhshadrach
TYP: obj in aggregation.py (pandas-dev#37532)
e0c99ec
ukarroum pushed a commit to ukarroum/pandas that referenced this pull request Nov 2, 2020
@rhshadrach @ukarroum
TYP: obj in aggregation.py (pandas-dev#37532)
278ac7c
@rhshadrach rhshadrach deleted the agg_obj_type branch December 6, 2020 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Apply Apply, Aggregate, Transform, Map Typing type annotations, mypy/pyright type checking
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.
2 participants
@rhshadrach @jreback