REF: share delete, putmask, insert between ndarray-backed EA indexes #37529
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
added
ExtensionArray
jreback
requested changes
Oct 31, 2020
| ) | ||
| if isinstance(loc, slice) and loc.step in (1, None): | ||
| if loc.start in (0, None) or loc.stop in (len(self), None): | ||
| elif self.freq is not None: |
There was a problem hiding this comment.
i am not sure that these specific freq routines are really worth it given the extra code. Can't we just re-infer the freq? (sure if we do this constantly its not as performant, but this is not likey a common case).
ok for here, but if you can have a look at some point
There was a problem hiding this comment.
thats a reasonable thought. i recently found a PITA bug in infer_freq though, so definitely not until that is sorted out
There was a problem hiding this comment.
kk maybe worthile to create an issue to see what implications / address later is.
jreback
approved these changes
Oct 31, 2020
kesmit13
pushed a commit
to kesmit13/pandas
that referenced
this pull request
Nov 2, 2020
ukarroum
pushed a commit
to ukarroum/pandas
that referenced
this pull request
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.