TST/REF: collect indexing tests by method #37507
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
approved these changes
Oct 30, 2020
mroeschke
added
the
Testing
jreback
reviewed
Oct 30, 2020
| @@ -19,3 +19,24 @@ def test_series_set_value(): | |||
| expected = Series([1.0, np.nan], index=index) | |||
|
|
|||
| tm.assert_series_equal(s, expected) | |||
|
|
|||
|
|
|||
| def test_set_value_dt64(datetime_series): | |||
There was a problem hiding this comment.
you really want to create a module named this? e.g. i would put this in setitem / setloc (not sure if we have that)
There was a problem hiding this comment.
its for the Series._set_value method. next time you want to write a test for that method you'll know exactly where it goes.
There was a problem hiding this comment.
ahh ok, yeah that's the biggest thing is to put new tests in the right place.
|
needs a rebase and a comment |
|
kk merge on green |
kesmit13
pushed a commit
to kesmit13/pandas
that referenced
this pull request
Nov 2, 2020
* TST/REF: indexing tests by method * TST: collect indexing tests by method
ukarroum
pushed a commit
to ukarroum/pandas
that referenced
this pull request
Nov 2, 2020
* TST/REF: indexing tests by method * TST: collect indexing tests by method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.