Skip to content

REGR: revert behaviour of getitem with assigning with a Series #37502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jorisvandenbossche
Copy link
Member

Closes #37427

@jbrockmendel this is reverting part of the clean-up you did in #33643. I think the behavioural change was unintentional in that PR. We might still want to do it for 1.2, but then with a deprecation first.

@jorisvandenbossche jorisvandenbossche added Regression Functionality that used to work in a prior pandas version Indexing Related to indexing on series/frames, not to indexes themselves labels Oct 29, 2020
@jorisvandenbossche jorisvandenbossche added this to the 1.1.4 milestone Oct 29, 2020
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. apparently a checks error though.

@jorisvandenbossche jorisvandenbossche merged commit 5492ed7 into pandas-dev:master Oct 30, 2020
@jorisvandenbossche jorisvandenbossche deleted the getitem-with-series branch October 30, 2020 08:15
@jorisvandenbossche
Copy link
Member Author

@meeseeksdev backport to 1.1.x

@lumberbot-app
Copy link

lumberbot-app bot commented Oct 30, 2020

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout 1.1.x
$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 5492ed7d4a9fdc310b26d773baebebce4e0e2dde
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am 'Backport PR #37502: REGR: revert behaviour of getitem with assigning with a Series'
  1. Push to a named branch :
git push YOURFORK 1.1.x:auto-backport-of-pr-37502-on-1.1.x
  1. Create a PR against branch 1.1.x, I would have named this PR:

"Backport PR #37502 on branch 1.1.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free to suggest an improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Indexing Related to indexing on series/frames, not to indexes themselves Regression Functionality that used to work in a prior pandas version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: NBC change in reindexing logic of Series.__setitem__ in pandas=1.1.0
2 participants