Skip to content

CI: xfail windows numexpr test #37435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 27, 2020
Merged

CI: xfail windows numexpr test #37435

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eccbb14
CI: xfail windows numexpr test
jbrockmendel Oct 26, 2020
e8445a2
tighten condition
jbrockmendel Oct 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion pandas/tests/computation/test_eval.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@
from numpy.random import rand, randint, randn
import pytest

from pandas.compat import is_platform_windows
from pandas.compat.numpy import np_version_under1p17
from pandas.errors import PerformanceWarning
import pandas.util._test_decorators as td

Expand Down Expand Up @@ -197,7 +199,23 @@ def test_simple_cmp_ops(self, cmp_op):
self.check_simple_cmp_op(lhs, cmp_op, rhs)

@pytest.mark.parametrize("op", _good_arith_ops)
def test_binary_arith_ops(self, op, lhs, rhs):
def test_binary_arith_ops(self, op, lhs, rhs, request):

if (
op == "/"
and isinstance(lhs, DataFrame)
and isinstance(rhs, DataFrame)
and not lhs.isna().any().any()
and rhs.shape == (10, 5)
and np_version_under1p17
and is_platform_windows()
and compat.PY38
):
mark = pytest.mark.xfail(
reason="GH#37328 floating point precision on Windows builds"
)
request.node.add_marker(mark)

self.check_binary_arith_op(lhs, op, rhs)

def test_modulus(self, lhs, rhs):
Expand Down