TST/REF: collect tests by method from generic #37421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
reviewed
Oct 27, 2020
| @@ -76,8 +69,7 @@ def test_get_numeric_data_preserve_dtype(self): | |||
| expected = DataFrame(index=[0, 1, 2], dtype=object) | |||
| self._compare(result, expected) | |||
|
|
|||
| def test_metadata_propagation_indiv(self): | |||
|
|
|||
| def test_metadata_propagation_indiv_groupby(self): | |||
There was a problem hiding this comment.
hmm thought we had a specific module for metadata tests
There was a problem hiding this comment.
@TomAugspurger is there a better home for these?
There was a problem hiding this comment.
Sorry for the delay. We have some in pandas/tests/generic/test_finalize.py.
jreback
reviewed
Oct 27, 2020
| @@ -534,7 +511,7 @@ def test_pct_change(self, periods, fill_method, limit, exp): | |||
| class TestNDFrame: | |||
| # tests that don't fit elsewhere | |||
|
|
|||
| def test_sample(sel): | |||
There was a problem hiding this comment.
wow, wonder how this worked
kesmit13
pushed a commit
to kesmit13/pandas
that referenced
this pull request
Nov 2, 2020
ukarroum
pushed a commit
to ukarroum/pandas
that referenced
this pull request
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff