CI/CLN: Lint more class references in tests #37401
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsaxton
added
CI
dsaxton
changed the title
|
I take it this is a get-it-all-done-at once PR? |
It started out as just MultiIndex, then I may have gotten a bit carried away |
|
needs rebase |
jreback
requested changes
Oct 30, 2020
| @@ -146,7 +146,7 @@ if [[ -z "$CHECK" || "$CHECK" == "patterns" ]]; then | |||
| RET=$(($RET + $?)) ; echo $MSG "DONE" | |||
|
|
|||
| MSG='Check for inconsistent use of pandas namespace in tests' ; echo $MSG | |||
| for class in "Series" "DataFrame" "Index"; do | |||
| for class in "Series" "DataFrame" "Index" "MultiIndex" "Timestamp" "Timedelta" "TimedeltaIndex" "DatetimeIndex" "Categorical"; do | |||
There was a problem hiding this comment.
didn't we move these to pre-commit?
There was a problem hiding this comment.
I don't think that's been done yet but @MarcoGorelli seemed to think it was doable
There was a problem hiding this comment.
On my to-do list 😇 I hope to get round to it next week
|
@jreback This is rebased and almost green if we want to merge and avoid more conflicts |
jreback
approved these changes
Oct 30, 2020
|
thanks @dsaxton |
kesmit13
pushed a commit
to kesmit13/pandas
that referenced
this pull request
Nov 2, 2020
* CI/CLN: Lint MultiIndex in tests * CI/CLN: Lint Timestamp in tests * Lint * Categorical * Fix
ukarroum
pushed a commit
to ukarroum/pandas
that referenced
this pull request
Nov 2, 2020
* CI/CLN: Lint MultiIndex in tests * CI/CLN: Lint Timestamp in tests * Lint * Categorical * Fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.