TST: parametrize slow test #37339
Merged
TST: parametrize slow test #37339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Oct 22, 2020
| @@ -7,17 +7,46 @@ | |||
| from pandas import DataFrame, Series | |||
| import pandas._testing as tm | |||
|
|
|||
| m = 50 | |||
There was a problem hiding this comment.
shouldnt u do this in a function where u set the random seed? not sure it's a big deal
There was a problem hiding this comment.
we dont set randomseed in this module. i dont think it makes real difference
There was a problem hiding this comment.
right but this should still be in a function and just create a fixture out of it
There was a problem hiding this comment.
actually this is fine, i realize its the only thing in this file.
jreback
added
Indexing
jreback
approved these changes
Oct 22, 2020
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Oct 26, 2020
kesmit13
pushed a commit
to kesmit13/pandas
that referenced
this pull request
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.