DOC: Remove confusing description from core.DataFrame.iterrows
#37331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takegue
force-pushed
the
improve-doc-takegue
branch
from
8f40a4f to
2e9c615
Compare
phofl
reviewed
Oct 22, 2020
pandas/core/frame.py
Outdated
| @@ -971,8 +971,6 @@ def iterrows(self) -> Iterable[Tuple[Label, Series]]: | |||
| data : Series | |||
| The data of the row as a Series. | |||
|
|
|||
| it : generator | |||
| A generator that iterates over the rows of the frame. | |||
|
|
|||
There was a problem hiding this comment.
Could you please remove one of the empty rows? Double emtpy rows are not allowed
There was a problem hiding this comment.
Okay! Thx for your review. I'll fix it.
phofl
approved these changes
Oct 23, 2020
jorisvandenbossche
approved these changes
Oct 23, 2020
|
lgtm whenever green. not sure CI failure was related but restarted in any case |
|
Thanks @TKNGUE ! |
fangchenli
pushed a commit
to fangchenli/pandas
that referenced
this pull request
Oct 24, 2020
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Oct 26, 2020
kesmit13
pushed a commit
to kesmit13/pandas
that referenced
this pull request
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current
core.DataFrame.iterrowsis as followsHowever,
core.DataFrame.iterrowsactually returns an iterator which yields(index, data), not(index, data, it).This PRs remove such confusing description like [https://pandas.pydata.org/pandas-docs/stable/reference/api/pandas.DataFrame.iteritems.html?highlight=yields]
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff