Skip to content

TST/REF: collect _libs tests #37324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Oct 22, 2020
Merged

TST/REF: collect _libs tests #37324

merged 8 commits into from
Oct 22, 2020

Conversation

jbrockmendel
Copy link
Member

No description provided.

@jreback jreback added the Testing pandas testing functions or related to the test suite label Oct 22, 2020
@jreback jreback added this to the 1.2 milestone Oct 22, 2020
@@ -0,0 +1,237 @@
import numpy as np
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about a counter proposal. can we make a libs/ sub-dir in pandas/tests/groupby (and similar for reshape)?

I find that if these are in different trees then people have no idea where to put the tests.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated+greenish

@jreback jreback merged commit 838cbd4 into pandas-dev:master Oct 22, 2020
@jbrockmendel jbrockmendel deleted the tst-libs branch October 22, 2020 22:16
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Oct 26, 2020
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants