BUG: Allow empty chunksize in stata reader when using iterator #37302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bashtage
added
IO Stata
jreback
reviewed
Oct 21, 2020
pandas/io/stata.py
Outdated
| "chunksize must be set to a positive integer to use as an iterator." | ||
| ) | ||
| return self.read(nrows=self._chunksize or 1) | ||
| self._chunksize = 1 if self._chunksize is None else self._chunksize |
There was a problem hiding this comment.
is there validation when chunsize is passed in?
There was a problem hiding this comment.
It is not checked when set. I've refactored the code to not rely on chunksize being set to determine if an iterator is being used.
There was a problem hiding this comment.
what i mean is what if someone passes chunksize<=0 ? do we appropriately raise
There was a problem hiding this comment.
Yes, there is explicit validation to ensure that it is an int that is >0
Lines 1049 to 1052 in b2ea05f
|
can you add a what's new note for the precision loss change (1.1.4) |
|
also pls merge master |
bashtage
force-pushed
the
stata-chunksize
branch
from
a1e2b9a to
574eebd
Compare
|
I rebased on master and added a what's new. |
bashtage
force-pushed
the
stata-chunksize
branch
from
574eebd to
5ad63c0
Compare
bashtage
force-pushed
the
stata-chunksize
branch
from
5ad63c0 to
54dc791
Compare
|
small conflict and pls rebase |
bashtage
force-pushed
the
stata-chunksize
branch
from
54dc791 to
2bfc4ae
Compare
Remvoe error message inorrectl added Fixed new issues identified by mypy Add test to ensure conversion of large ints is correct closes pandas-dev#37280
bashtage
force-pushed
the
stata-chunksize
branch
from
2bfc4ae to
b2ea05f
Compare
|
thanks @bashtage |
|
@meeseeksdev backport 1.1.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Oct 23, 2020
…der when using iterator
simonjayhawkins
added a commit
that referenced
this pull request
Oct 24, 2020
…ta reader when using iterator) (#37364) * Backport PR #37302: BUG: Allow empty chunksize in stata reader when using iterator * remove match argument to assert_produces_warning Co-authored-by: Kevin Sheppard <[email protected]> Co-authored-by: Simon Hawkins <[email protected]>
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Oct 26, 2020
Remvoe error message inorrectl added Fixed new issues identified by mypy Add test to ensure conversion of large ints is correct closes pandas-dev#37280
kesmit13
pushed a commit
to kesmit13/pandas
that referenced
this pull request
Nov 2, 2020
Remvoe error message inorrectl added Fixed new issues identified by mypy Add test to ensure conversion of large ints is correct closes pandas-dev#37280
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff