Skip to content

DOC: Replace pandas on Ray in ecosystem.rst with Modin #37249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 20, 2020

Conversation

devin-petersohn
Copy link
Contributor

Signed-off-by: Devin Petersohn [email protected]

@TomAugspurger
Copy link
Contributor

@datapythonista have you seen this GitHub API rate limit issue before?

  File "/home/runner/work/pandas/pandas/web/pandas_web.py", line 154, in maintainers_add_info
    resp.raise_for_status()
  File "/home/runner/miniconda3/envs/pandas-dev/lib/python3.8/site-packages/requests/models.py", line 941, in raise_for_status
    raise HTTPError(http_error_msg, response=self)
requests.exceptions.HTTPError: 403 Client Error: rate limit exceeded for url: https://api.github.com/users/gfyoung
Error: Process completed with exit code 1.

@datapythonista
Copy link
Member

@datapythonista have you seen this GitHub API rate limit issue before?

Yes, I was having it all the time when doing tests with the website locally. To render the Team page, we call the GitHub API for the photos and names of the active maintainers. There is an hourly quote, so if number of doc builds in one hour * number of maintainers > GitHub quota, then this will happen.

I guess the quota is per ip, so not sure how different builds impact the quota.

For this PR, just retrying a bit later will fix the issue. For the future, I see two options:

  • Trivial: Move active maintainers to emeritus maintainers for who it makes sense, and that will make it more unlikely to happen
  • Find a way to avoid calling the GitHub API on PRs, since only the website rendered in master builds is published

@devin-petersohn
Copy link
Contributor Author

Has it been long enough to retry? @datapythonista @TomAugspurger

@datapythonista
Copy link
Member

I think so, reruning the CI...

Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @devin-petersohn

@jreback jreback added the Docs label Oct 20, 2020
@jreback jreback added this to the 1.2 milestone Oct 20, 2020
@jreback jreback merged commit 13df3ec into pandas-dev:master Oct 20, 2020
@jreback
Copy link
Contributor

jreback commented Oct 20, 2020

thanks @devin-petersohn

JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Oct 26, 2020
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
@devin-petersohn
Copy link
Contributor Author

@datapythonista @TomAugspurger I have not seen the changes propagate to the documentation, is there a problem with the changes?

https://pandas.pydata.org/docs/ecosystem.html

@TomAugspurger
Copy link
Contributor

TomAugspurger commented Nov 17, 2020 via email

@datapythonista
Copy link
Member

We have some duplicated pages, the ecosystem is one of them. You changed it in the docs, and I'm not sure where that is being rendered (@jorisvandenbossche should know), and the one you're linking is to the web.

This was discussed some time ago in #29586, but there was no consensus to delete the copy in the docs, so the two copies were left. You can open another PR for the doc in the website, sorry for the extra work.

@datapythonista
Copy link
Member

Ups, sorry, Tom is right, I got confused. The web version is at https://pandas.pydata.org/community/ecosystem.html and updates as soon as the PR is merged, but for the docs one, you'll have to wait until the next release.

@devin-petersohn
Copy link
Contributor Author

Makes sense, thank you @TomAugspurger and @datapythonista!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC: Replace pandas on Ray in ecosystem.rst with Modin
4 participants