-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
DOC: Replace pandas on Ray in ecosystem.rst with Modin #37249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* Resolves pandas-dev#37247 Signed-off-by: Devin Petersohn <[email protected]>
@datapythonista have you seen this GitHub API rate limit issue before?
|
Yes, I was having it all the time when doing tests with the website locally. To render the I guess the quota is per ip, so not sure how different builds impact the quota. For this PR, just retrying a bit later will fix the issue. For the future, I see two options:
|
Has it been long enough to retry? @datapythonista @TomAugspurger |
I think so, reruning the CI... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks @devin-petersohn
thanks @devin-petersohn |
@datapythonista @TomAugspurger I have not seen the changes propagate to the documentation, is there a problem with the changes? |
The version at /docs are updated with releases (this was in 1.2 I think).
https://pandas.pydata.org/pandas-docs/dev/ecosystem.html <https://pandas.pydata.org/pandas-docs/dev/ecosystem.html> should have the changes.
… On Nov 17, 2020, at 10:51 AM, Devin Petersohn ***@***.***> wrote:
@datapythonista <https://github.com/datapythonista> @TomAugspurger <https://github.com/TomAugspurger> I have not seen the changes propagate to the documentation, is there a problem with the changes?
https://pandas.pydata.org/docs/ecosystem.html <https://pandas.pydata.org/docs/ecosystem.html>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#37249 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAKAOIVCM67LHM72MDYFURTSQKSZXANCNFSM4SWGXAFA>.
|
We have some duplicated pages, the ecosystem is one of them. You changed it in the docs, and I'm not sure where that is being rendered (@jorisvandenbossche should know), and the one you're linking is to the web. This was discussed some time ago in #29586, but there was no consensus to delete the copy in the docs, so the two copies were left. You can open another PR for the doc in the website, sorry for the extra work. |
Ups, sorry, Tom is right, I got confused. The web version is at https://pandas.pydata.org/community/ecosystem.html and updates as soon as the PR is merged, but for the docs one, you'll have to wait until the next release. |
Makes sense, thank you @TomAugspurger and @datapythonista! |
Signed-off-by: Devin Petersohn [email protected]
black pandas
git diff upstream/master -u -- "*.py" | flake8 --diff