REF: move get_op_result_name out of ops.__init__ #37231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
reviewed
Oct 19, 2020
| @@ -25,7 +25,10 @@ | |||
| get_array_op, | |||
| logical_op, | |||
| ) | |||
| from pandas.core.ops.common import unpack_zerodim_and_defer # noqa:F401 | |||
| from pandas.core.ops.common import ( # noqa:F401 | |||
There was a problem hiding this comment.
sure i assume that you want to remove the noqa entirely from here
jreback
approved these changes
Oct 19, 2020
jreback
added
Clean
Numeric Operations
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Oct 26, 2020
kesmit13
pushed a commit
to kesmit13/pandas
that referenced
this pull request
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slowly chipping away at the long-time goal of not having a bunch of code in
ops.__init__