Skip to content

TST: indexing tests for #21168, #27420, #15928, #30053 #37228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 20, 2020

Conversation

@jreback jreback changed the title TST: tests for #21168, #27420, #15928, #30053 TST: indexing tests for #21168, #27420, #15928, #30053 Oct 19, 2020
@jreback jreback added Indexing Related to indexing on series/frames, not to indexes themselves Testing pandas testing functions or related to the test suite labels Oct 19, 2020
@jreback jreback added this to the 1.2 milestone Oct 19, 2020

def test_getitem_str_slice():
# GH#15928
path = os.path.join(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of doing this can you use datapath fixture, maybe
datapath("reshape", "merge", "data", "quotes2.csv")

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, just pushed with update

@jreback
Copy link
Contributor

jreback commented Oct 19, 2020

lgtm merge when green-ish (something failing on master?)

@jbrockmendel jbrockmendel merged commit c908355 into pandas-dev:master Oct 20, 2020
@jbrockmendel jbrockmendel deleted the needs-tests branch October 20, 2020 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Indexing Related to indexing on series/frames, not to indexes themselves Testing pandas testing functions or related to the test suite
Projects
None yet
2 participants