TYP: indexes

pandas/core/indexes/category.py

@@ -235,20 +235,23 @@ def _shallow_copy(self, values=None, name: Label = no_default):
 
         return super()._shallow_copy(values=values, name=name)
 
-    def _is_dtype_compat(self, other) -> bool:
+    def _is_dtype_compat(self, other) -> Categorical:
         """
         *this is an internal non-public method*
 
         provide a comparison between the dtype of self and other (coercing if
         needed)
 
+        Returns
+        -------
+        Categorical
+
         Raises
         ------
         TypeError if the dtypes are not compatible
         """
         if is_categorical_dtype(other):
-            if isinstance(other, CategoricalIndex):
-                other = other._values
+            other = extract_array(other)
             if not other.is_dtype_equal(self):
                 raise TypeError(
                     "categories must match existing categories when appending"
@@ -263,6 +266,7 @@ def _is_dtype_compat(self, other) -> bool:
                 raise TypeError(
                     "cannot append a non-category item to a CategoricalIndex"
                 )
+            other = other._values
 
         return other
 

pandas/core/indexes/datetimelike.py

@@ -43,7 +43,7 @@
 from pandas.core.tools.timedeltas import to_timedelta
 
 if TYPE_CHECKING:
-    from pandas import CategoricalIndex
+    from pandas import CategoricalIndex, DatetimeIndex
 
 _index_doc_kwargs = dict(ibase._index_doc_kwargs)
 
@@ -953,6 +953,9 @@ def _maybe_utc_convert(self, other):
                 raise TypeError("Cannot join tz-naive with tz-aware DatetimeIndex")
 
             if not timezones.tz_compare(self.tz, other.tz):
+                self = cast("DatetimeIndex", self)
+                other = cast("DatetimeIndex", other)
+
                 this = self.tz_convert("UTC")
                 other = other.tz_convert("UTC")
         return this, other

pandas/core/indexes/interval.py

@@ -1302,10 +1302,8 @@ def interval_range(
     else:
         # delegate to the appropriate range function
         if isinstance(endpoint, Timestamp):
-            range_func = date_range
+            breaks = date_range(start=start, end=end, periods=periods, freq=freq)
         else:
-            range_func = timedelta_range
-
-        breaks = range_func(start=start, end=end, periods=periods, freq=freq)
+            breaks = timedelta_range(start=start, end=end, periods=periods, freq=freq)
 
     return IntervalIndex.from_breaks(breaks, name=name, closed=closed)

pandas/core/indexes/period.py

@@ -161,6 +161,21 @@ def to_timestamp(self, freq=None, how="start") -> DatetimeIndex:
         arr = self._data.to_timestamp(freq, how)
         return DatetimeIndex._simple_new(arr, name=self.name)
 
+    # TODO: use @doc(PeriodArray.hour) once mypy supports
+    @property
+    def hour(self) -> Int64Index:
+        return Int64Index(self._data.hour, name=self.name)
+
+    # TODO: use @doc(PeriodArray.minute) once mypy supports
+    @property
+    def minute(self) -> Int64Index:
+        return Int64Index(self._data.minute, name=self.name)
+
+    # TODO: use @doc(PeriodArray.second) once mypy supports
+    @property
+    def second(self) -> Int64Index:
+        return Int64Index(self._data.second, name=self.name)
+
     # ------------------------------------------------------------------------
     # Index Constructors
 

pandas/core/reshape/concat.py

@@ -455,6 +455,7 @@ def __init__(
         self.new_axes = self._get_new_axes()
 
     def get_result(self):
+        from pandas import DataFrame, Series
 
         # series only
         if self._is_series:
@@ -463,6 +464,7 @@ def get_result(self):
             if self.bm_axis == 0:
                 name = com.consensus_name_attr(self.objs)
                 cons = self.objs[0]._constructor
+                assert issubclass(cons, Series)  # for mypy
 
                 arrs = [ser._values for ser in self.objs]
 
@@ -476,6 +478,7 @@ def get_result(self):
 
                 # GH28330 Preserves subclassed objects through concat
                 cons = self.objs[0]._constructor_expanddim
+                assert issubclass(cons, DataFrame)  # for mypy
 
                 index, columns = self.new_axes
                 df = cons(data, index=index)

pandas/io/parsers.py

@@ -2179,7 +2179,7 @@ def TextParser(*args, **kwds):
     return TextFileReader(*args, **kwds)
 
 
-def count_empty_vals(vals):
+def count_empty_vals(vals) -> int:
     return sum(1 for v in vals if v == "" or v is None)
 
 

setup.cfg

@@ -181,18 +181,12 @@ check_untyped_defs=False
 [mypy-pandas.core.indexes.extension]
 check_untyped_defs=False
 
-[mypy-pandas.core.indexes.interval]
-check_untyped_defs=False
-
 [mypy-pandas.core.indexes.multi]
 check_untyped_defs=False
 
 [mypy-pandas.core.resample]
 check_untyped_defs=False
 
-[mypy-pandas.core.reshape.concat]
-check_untyped_defs=False
-
 [mypy-pandas.core.reshape.merge]
 check_untyped_defs=False
 
@@ -214,9 +208,6 @@ check_untyped_defs=False
 [mypy-pandas.io.parsers]
 check_untyped_defs=False
 
-[mypy-pandas.plotting._matplotlib.converter]
-check_untyped_defs=False
-
 [mypy-pandas.plotting._matplotlib.core]
 check_untyped_defs=False