-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BUG: Join did not work correctly when one MultiIndex had only one level #37208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
88c3337
BUG: join did not work correctly when one MultiIndex had only one level
phofl fd06392
Change pr number
phofl ce10f5f
Merge branch 'master' of https://github.com/pandas-dev/pandas into 36909
phofl d57f186
Move whatsnew
phofl 42135d2
Remove pd
phofl da316f0
Usef fixture
phofl bd063c8
Remove len self
phofl 436f7c4
Merge branch 'master' of https://github.com/pandas-dev/pandas into 36909
phofl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -815,3 +815,20 @@ def test_join_cross(input_col, output_cols): | |
result = left.join(right, how="cross", lsuffix="_x", rsuffix="_y") | ||
expected = DataFrame({output_cols[0]: [1, 1, 3, 3], output_cols[1]: [3, 4, 3, 4]}) | ||
tm.assert_frame_equal(result, expected) | ||
|
||
|
||
@pytest.mark.parametrize("how", ["left", "right", "inner", "outer"]) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. don't we have a fixture for this? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Oh, yes. thx |
||
def test_join_multiindex_one_level(how): | ||
# GH#36909 | ||
left = DataFrame( | ||
data={"c": 3}, index=pd.MultiIndex.from_tuples([(1, 2)], names=("a", "b")) | ||
) | ||
right = DataFrame( | ||
data={"d": 4}, index=pd.MultiIndex.from_tuples([(2,)], names=("b",)) | ||
) | ||
result = left.join(right, how=how) | ||
expected = DataFrame( | ||
{"c": [3], "d": [4]}, | ||
index=pd.MultiIndex.from_tuples([(2, 1)], names=["b", "a"]), | ||
) | ||
tm.assert_frame_equal(result, expected) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this len(self) > 1 is a very odd check, what is the intent?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to be no longer necessary. Code changed quite a bit since I implemented this. Removed it.