Tests for where() with categorical #37182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arw2019
suggested changes
Oct 17, 2020
There was a problem hiding this comment.
Thanks @gabriellm1 for the PR!
Some comments.
I would use the pytest.mark.parametrize to put these tests together. Possibly you want to parametrize on klass (which could be Series or DataFrame) - take a look in other tests for examples.
No need for a whatsnew since this isn't making a user facing change.
Let me know if you have any questions!
jreback
added
Categorical
|
thanks @gabriellm1 |
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Oct 26, 2020
kesmit13
pushed a commit
to kesmit13/pandas
that referenced
this pull request
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
whereseries method #18888black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffHey everyone,
I wrote some tests for issue #18888. I don't know exactly if the format is correct but if any change is needed I'm happy to make it right.
Which 'whatsnew entry' should I report for both new tests?
Also, if you think this is a decent contribution and if there's no problem with doing that, it would be nice to tag this PR with hacktoberfest-accepted label :)