Skip to content

BUG: use cls instead of MultiIndex in MultiIndex classmethods #37180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 17, 2020

Conversation

jbrockmendel
Copy link
Member

This doesn't go through all the places where MultiIndex is hard-coded, just the classmethods where in cls should be used as a matter of principle.

@jreback jreback added Compat pandas objects compatability with Numpy or Python functions MultiIndex labels Oct 16, 2020
@jreback jreback added this to the 1.2 milestone Oct 16, 2020
@jreback
Copy link
Contributor

jreback commented Oct 16, 2020

yep merge on green

@jbrockmendel jbrockmendel merged commit 1ce2a74 into pandas-dev:master Oct 17, 2020
@jbrockmendel jbrockmendel deleted the mi_subclass branch October 17, 2020 01:51
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Compat pandas objects compatability with Numpy or Python functions MultiIndex
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot subclass MultiIndex
2 participants