BUG: Fix bug in quantile() for resample and groupby with Timedelta #37145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhshadrach
requested changes
Oct 22, 2020
� Conflicts: � doc/source/whatsnew/v1.2.0.rst
|
Sorry, was waiting for some kind of feedback :) Changed the whatsnew |
rhshadrach
requested changes
Oct 27, 2020
doc/source/whatsnew/v1.2.0.rst
Outdated
| @@ -495,6 +495,7 @@ Groupby/resample/rolling | |||
| - Bug in :meth:`DataFrame.groupby.rolling` returning wrong values with partial centered window (:issue:`36040`). | |||
| - Bug in :meth:`DataFrameGroupBy.rolling` returned wrong values with timeaware window containing ``NaN``. Raises ``ValueError`` because windows are not monotonic now (:issue:`34617`) | |||
| - Bug in :meth:`Rolling.__iter__` where a ``ValueError`` was not raised when ``min_periods`` was larger than ``window`` (:issue:`37156`) | |||
| - Bug in :meth:`df.groupby(..).quantile() <pandas.core.groupby.DataFrameGroupBy.quantile>` and :meth:`df.resample(..).quantile() <pandas.core.resample.Resampler.quantile>` raised ``TypeError`` when values to calculate quantile over where ``Timedelta`` (:issue:`29485`) | |||
There was a problem hiding this comment.
where -> were. Also, I think it's okay to just say e.g. "when values were of type Timedelta"
� Conflicts: � doc/source/whatsnew/v1.2.0.rst
|
Windows py38_np18 failed to start, Windows py37_np16 failed on |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Same result. @phofl Can you merge master? |
|
Done |
jreback
reviewed
Oct 29, 2020
jreback
approved these changes
Oct 29, 2020
|
Failure seems unrelated |
rhshadrach
approved these changes
Oct 30, 2020
|
thanks @phofl |
kesmit13
pushed a commit
to kesmit13/pandas
that referenced
this pull request
Nov 2, 2020
ukarroum
pushed a commit
to ukarroum/pandas
that referenced
this pull request
Nov 2, 2020
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff