Add test_masking_duplicate_columns #37125
Conversation
jreback
added
the
Indexing
|
Somehow I missed that, it's now fixed, thanks @dsaxton |
| @@ -513,3 +513,10 @@ def test_set_value_by_index(self): | |||
|
|
|||
| df.iloc[:, 0] = 3 | |||
| tm.assert_series_equal(df.iloc[:, 1], expected) | |||
|
|
|||
There was a problem hiding this comment.
can you construct this exactly as in the OP; e.g. we want these converted to numpy before the constructor. also pls parameterize as there are multiple tests indicated
There was a problem hiding this comment.
Hmm, I am not sure I follow, what would be a good way to parameterize in this scope?
I saw that in order functions we have access to a check function, but if I were to put my test inside another function, it would probably be the test_columns_with_dups function, which has no access to this particular mechanism.
As for the numpy parts, I just added a commit to address that, maybe it is as it should be, thanks for the review!
There was a problem hiding this comment.
@jreback I think I misread your request the first time, you are saying there should be other cases for this test? Looking at the issue again it seems to me that this single test should be enough
|
Hello @GabrielSimonetto! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-10-18 18:14:20 UTC |
|
@GabrielSimonetto can you merge master and update to comments |
|
Closing in favor of #38354 |
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffI don't know what an whatsnew entry is...
This PR adds a test in order to solve an issue