Skip to content

REF: IntervalArray comparisons #37124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Nov 3, 2020
Merged

REF: IntervalArray comparisons #37124

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
a3b7c45
ENH: IntervalArray comparisons
jbrockmendel Oct 14, 2020
60197d2
Merge branch 'master' of https://github.com/pandas-dev/pandas into re…
jbrockmendel Oct 14, 2020
cf20846
CLN: get IntervalIndex comparisons from IntervalArray
jbrockmendel Oct 14, 2020
d3c1041
Merge branch 'master' of https://github.com/pandas-dev/pandas into re…
jbrockmendel Oct 20, 2020
fcfe47d
update per requests
jbrockmendel Oct 20, 2020
3dfc008
Merge branch 'master' of https://github.com/pandas-dev/pandas into re…
jbrockmendel Oct 23, 2020
fa6cecd
Avoid having to tile
jbrockmendel Oct 24, 2020
0d32acd
Merge branch 'master' of https://github.com/pandas-dev/pandas into re…
jbrockmendel Oct 24, 2020
ff640ea
handle NA per suggestion
jbrockmendel Oct 24, 2020
f501b4e
Merge branch 'master' of https://github.com/pandas-dev/pandas into re…
jbrockmendel Oct 27, 2020
247ce90
comment
jbrockmendel Oct 27, 2020
84b0409
Merge branch 'master' of https://github.com/pandas-dev/pandas into re…
jbrockmendel Oct 31, 2020
1ea125d
Merge branch 'master' of https://github.com/pandas-dev/pandas into re…
jbrockmendel Nov 1, 2020
6e43726
Merge branch 'master' of https://github.com/pandas-dev/pandas into re…
jbrockmendel Nov 2, 2020
badb99d
update comment
jbrockmendel Nov 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions pandas/core/arrays/_mixins.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import numpy as np

from pandas._libs import lib
from pandas.compat.numpy import function as nv
from pandas.errors import AbstractMethodError
from pandas.util._decorators import cache_readonly, doc
from pandas.util._validators import validate_fillna_kwargs
Expand Down Expand Up @@ -138,6 +139,7 @@ def repeat(self: _T, repeats, axis=None) -> _T:
--------
numpy.ndarray.repeat
"""
nv.validate_repeat(tuple(), dict(axis=axis))
new_data = self._ndarray.repeat(repeats, axis=axis)
return self._from_backing_data(new_data)

Expand Down
2 changes: 2 additions & 0 deletions pandas/core/arrays/interval.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -583,6 +583,8 @@ def _cmp_method(self, other, op):
result[i] = op(self[i], obj)
except TypeError:
if obj is NA:
# comparison returns NA, which we (for now?) treat like
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's actually only for comparison of np.nan with pd.NA, comparison with Intervals is already (for now) returning False

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you suggest an edit so i can just hit "commit" on it

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated per request + green

# other NAs
# github.com/pandas-dev/pandas/pull/37124#discussion_r509095092
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment with an actual explanation instead of (only) the link?

result[i] = op is operator.ne
else:
Expand Down