Skip to content

PERF: regression in DataFrame reduction ops performance #37081 #37118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 17, 2020
Merged

PERF: regression in DataFrame reduction ops performance #37081 #37118

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6357ac2
[PERF] Fixed issue #37081
ukarroum Oct 14, 2020
41827fb
PERF : #37081 Compute dtypes once for 'any_object' and 'dtype_is_dt'
ukarroum Oct 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions pandas/core/frame.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8652,11 +8652,10 @@ def _reduce(
assert filter_type is None or filter_type == "bool", filter_type
out_dtype = "bool" if filter_type == "bool" else None

own_dtypes = [arr.dtype for arr in self._iter_column_arrays()]

dtype_is_dt = np.array(
[
is_datetime64_any_dtype(values.dtype)
for values in self._iter_column_arrays()
],
[is_datetime64_any_dtype(dtype) for dtype in own_dtypes],
dtype=bool,
)
if numeric_only is None and name in ["mean", "median"] and dtype_is_dt.any():
Expand All @@ -8670,7 +8669,11 @@ def _reduce(
cols = self.columns[~dtype_is_dt]
self = self[cols]

any_object = self.dtypes.apply(is_object_dtype).any()
any_object = np.array(
[is_object_dtype(dtype) for dtype in own_dtypes],
dtype=bool,
).any()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's only find the dtypes once (i.e. share with dtype_is_dt above

own_dtypes = [arr.dtype for arr in self._iter_column_arrays()]
# or 
own_dtypes = [blk.dtype for blk in self._mgr.blocks]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done in 41827fb


# TODO: Make other agg func handle axis=None properly GH#21597
axis = self._get_axis_number(axis)
labels = self._get_agg_axis(axis)
Expand Down