Skip to content

CI: check for numpy.random-related imports #37117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Oct 31, 2020
Merged

CI: check for numpy.random-related imports #37117

Changes from 2 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
e1dee07
UPD: check for numpy.random-related imports
onshek Oct 14, 2020
a07c287
UPD: code_checks.sh
onshek Oct 25, 2020
3f6223d
Revert "UPD: code_checks.sh"
onshek Oct 31, 2020
8d85be3
Revert "UPD: check for numpy.random-related imports"
onshek Oct 31, 2020
048354f
UPD: with master
onshek Oct 31, 2020
88438b9
Revert "UPD: with master"
onshek Oct 31, 2020
16d7df8
ADD: check for imports from np.random.<method>
onshek Oct 31, 2020
511ff15
Merge branch 'master' into issue37053-unify-numpy.random-related-imports
onshek Oct 31, 2020
c551e16
UPD: delete several blank lines
onshek Oct 31, 2020
fd1acd6
ADD: exclude pandas/_testing.py
onshek Oct 31, 2020
1e52ea5
UPD: name of the new check
onshek Oct 31, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ci/code_checks.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,11 @@ if [[ -z "$CHECK" || "$CHECK" == "patterns" ]]; then
invgrep -r -E --include '*.py' --exclude testing.py '(numpy|np)(\.testing|\.array_equal)' pandas/tests/
RET=$(($RET + $?)) ; echo $MSG "DONE"

# GH37053, Check for np.random.<method> instead of `from numpy.random import` or `from numpy import random`
MSG='Check for numpy.random-related imports' ; echo $MSG
invgrep -R --include="*.py" --exclude=_testing.py -E "(from numpy.random import)|(from numpy import random)" pandas
RET=$(($RET + $?)) ; echo $MSG "DONE"

# Check for the following code in the extension array base tests: `tm.assert_frame_equal` and `tm.assert_series_equal`
MSG='Check for invalid EA testing' ; echo $MSG
invgrep -r -E --include '*.py' --exclude base.py 'tm.assert_(series|frame)_equal' pandas/tests/extension/base
Expand Down