Skip to content

CLN: remove unnecessary Categorical._validate_setitem_key #37068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 12, 2020
Merged

CLN: remove unnecessary Categorical._validate_setitem_key #37068

merged 2 commits into from
Oct 12, 2020

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

and some unrelated cleanup in internals

@jreback jreback added Categorical Categorical Data Type Indexing Related to indexing on series/frames, not to indexes themselves Internals Related to non-user accessible pandas implementation labels Oct 12, 2020
@jreback jreback added this to the 1.2 milestone Oct 12, 2020
@jreback jreback merged commit b526620 into pandas-dev:master Oct 12, 2020
@jbrockmendel jbrockmendel deleted the ref-share-8 branch October 13, 2020 00:43
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Oct 26, 2020
@jbrockmendel @JulianWgs
CLN: remove unnecessary Categorical._validate_setitem_key (pandas-dev…
22fa9ac 
…#37068)
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
@jbrockmendel
CLN: remove unnecessary Categorical._validate_setitem_key (pandas-dev…
ac8625c 
…#37068)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Categorical Categorical Data Type Indexing Related to indexing on series/frames, not to indexes themselves Internals Related to non-user accessible pandas implementation
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.
2 participants
@jbrockmendel @jreback