Skip to content

TYP: core.internals #37058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 12, 2020
Merged

TYP: core.internals #37058

merged 4 commits into from
Oct 12, 2020

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

Annotating Block as Union[np.ndarray, ExtensionArray], mypy gives tons of complaints about EA not having .T, so this adds that, then updates tests as appropriate

@jreback jreback added Internals Related to non-user accessible pandas implementation Typing type annotations, mypy/pyright type checking labels Oct 11, 2020
@jreback jreback added this to the 1.2 milestone Oct 11, 2020
@@ -1081,6 +1081,19 @@ def _formatter(self, boxed: bool = False) -> Callable[[Any], Optional[str]]:
# Reshaping
# ------------------------------------------------------------------------

def transpose(self, *axes):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you type these

@jreback jreback merged commit 26576a8 into pandas-dev:master Oct 12, 2020
@jbrockmendel jbrockmendel deleted the typ-internals branch October 12, 2020 17:01
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Oct 26, 2020
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internals Related to non-user accessible pandas implementation Typing type annotations, mypy/pyright type checking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants