Skip to content

CLN: core/dtypes/cast.py::maybe_downcast_to_dtype #37050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Oct 14, 2020
Merged

CLN: core/dtypes/cast.py::maybe_downcast_to_dtype #37050

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
a8eba60
CLN: rewrite try/except/pass using contextlib.suppress
arw2019 Oct 10, 2020
058bf6f
use is_period_dtype to check type
arw2019 Oct 10, 2020
9eb0b67
clean up if condition
arw2019 Oct 10, 2020
c2ad3d9
add is_datetime_or_timedelta_any_dtype helper to dtypes/common
arw2019 Oct 10, 2020
9c06bc6
enact TODO: relocate PeriodArray block
arw2019 Oct 11, 2020
0a23240
feedback: revert changes to dtype checks
arw2019 Oct 11, 2020
e2d0375
reorder clause
arw2019 Oct 11, 2020
b5e53e9
feedback: collapse datetimelike if body
arw2019 Oct 11, 2020
d887566
revert datelike if-else body
arw2019 Oct 11, 2020
e46b10d
feedback: revert datetimelike block
arw2019 Oct 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 10 additions & 12 deletions pandas/core/dtypes/cast.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
Routines for casting.
"""

from contextlib import suppress
from datetime import date, datetime, timedelta
from typing import TYPE_CHECKING, Any, List, Optional, Tuple, Type

Expand Down Expand Up @@ -154,12 +155,20 @@ def maybe_downcast_to_dtype(result, dtype):

dtype = np.dtype(dtype)

elif dtype.type is Period:
from pandas.core.arrays import PeriodArray

with suppress(TypeError):
# e.g. TypeError: int() argument must be a string, a
# bytes-like object or a number, not 'Period
return PeriodArray(result, freq=dtype.freq)

converted = maybe_downcast_numeric(result, dtype, do_round)
if converted is not result:
return converted

# a datetimelike
# GH12821, iNaT is casted to float
# GH12821, iNaT is cast to float
if dtype.kind in ["M", "m"] and result.dtype.kind in ["i", "f"]:
if hasattr(dtype, "tz"):
# not a numpy dtype
Expand All @@ -172,17 +181,6 @@ def maybe_downcast_to_dtype(result, dtype):
else:
result = result.astype(dtype)

elif dtype.type is Period:
# TODO(DatetimeArray): merge with previous elif
from pandas.core.arrays import PeriodArray

try:
return PeriodArray(result, freq=dtype.freq)
except TypeError:
# e.g. TypeError: int() argument must be a string, a
# bytes-like object or a number, not 'Period
pass

return result


Expand Down