Skip to content

TST: Fix failing test from #37027 #37048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 11, 2020
Merged

Conversation

hongshaoyang
Copy link
Contributor

@hongshaoyang hongshaoyang commented Oct 11, 2020

Part of #30999

  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff

@dsaxton
Copy link
Member

dsaxton commented Oct 11, 2020

Is it possible to update the error messages to make CI pass rather than reverting entirely?

@dsaxton dsaxton added the Testing pandas testing functions or related to the test suite label Oct 11, 2020
@hongshaoyang hongshaoyang changed the title TST: Revert "TST: insert 'match' to bare pytest raises in pandas/tests/too… TST: Fix failing test from #37027 Oct 11, 2020
@hongshaoyang
Copy link
Contributor Author

hongshaoyang commented Oct 11, 2020

@dsaxton updated. all checks passed. could i get the hacktoberfest-accepted label for this PR?

@jreback jreback added this to the 1.2 milestone Oct 11, 2020
@jreback jreback merged commit 69aa2a8 into pandas-dev:master Oct 11, 2020
@jreback
Copy link
Contributor

jreback commented Oct 11, 2020

thanks much @hongshaoyang

@hongshaoyang hongshaoyang deleted the revert-37027 branch October 11, 2020 13:33
@jreback jreback mentioned this pull request Oct 11, 2020
5 tasks
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Oct 26, 2020
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants