-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DOC: Add summary to interpolate #37042
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mroeschke
merged 4 commits into
pandas-dev:master
from
erictleung:add-info-to-interpolate
Oct 15, 2020
Merged
DOC: Add summary to interpolate #37042
mroeschke
merged 4 commits into
pandas-dev:master
from
erictleung:add-info-to-interpolate
Oct 15, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This basic description can be useful for users who don't know what interpolation is and this may help with SEO to search for more powerful method than the `.fillna()` method.
In the "See Also" section of interpolate, the fillna method sounds very similar, but it actually is more limited. So this commit makes this distinction more clear.
arw2019
suggested changes
Oct 11, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @erictleung for the PR! Some comments
arw2019
approved these changes
Oct 11, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 on this as is
mroeschke
approved these changes
Oct 15, 2020
Thanks @erictleung |
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Oct 26, 2020
* DOC: add basic description to interpolate method This basic description can be useful for users who don't know what interpolation is and this may help with SEO to search for more powerful method than the `.fillna()` method. * DOC: update fillna info to contrast interpolate In the "See Also" section of interpolate, the fillna method sounds very similar, but it actually is more limited. So this commit makes this distinction more clear. * DOC: condense interpolate method summary text * DOC: revert description change of fillna
kesmit13
pushed a commit
to kesmit13/pandas
that referenced
this pull request
Nov 2, 2020
* DOC: add basic description to interpolate method This basic description can be useful for users who don't know what interpolation is and this may help with SEO to search for more powerful method than the `.fillna()` method. * DOC: update fillna info to contrast interpolate In the "See Also" section of interpolate, the fillna method sounds very similar, but it actually is more limited. So this commit makes this distinction more clear. * DOC: condense interpolate method summary text * DOC: revert description change of fillna
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandas
git diff upstream/master -u -- "*.py" | flake8 --diff
The interpolate method was missing a short summary. I hope this addition is reasonable. Happy to change it with feedback.