Skip to content

DOC: document read_html and to_html #3704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 30, 2013
Merged

DOC: document read_html and to_html #3704

merged 2 commits into from
May 30, 2013

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented May 28, 2013

No description provided.

@jreback
Copy link
Contributor

jreback commented May 28, 2013

FYI after #3693 u won't need to import read_html explicitly anymore

@cpcloud
Copy link
Member Author

cpcloud commented May 28, 2013

ok i will remove

@cpcloud
Copy link
Member Author

cpcloud commented May 28, 2013

i changed a few things around in html.py nothing major, but now read_html attempts to infer row and columns index types if they are not MultiIndexes. rls notes for this? it doesn't try to infer dates

@@ -925,8 +925,106 @@ Reading HTML Content

.. versionadded:: 0.11.1

The toplevel :func:`~pandas.io.parsers.read_html` function can accept an HTML
The toplevel :func:`~pandas.io.read_html` function can accept an HTML
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cpcloud this has nothing to do with your PR< but do you know why when you put an inline function reference its not a link? (what should it be?)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i changed it to this because it wasn't linking correctly (still not though since pandas.io.__init__ is empty. must've been looking at a different link when i built the docs...). it should link to the api docs. will fix

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its not your link, I see this type of thing elsewhere (e.g. in the Stata docs); if you figure it out we prob need to edit in several places

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm this is annoying

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jreback got it. u must put the exact module reference here so the above should be :func:~pandas.io.html.read_html``

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still annoying

@jreback
Copy link
Contributor

jreback commented May 30, 2013

you might need to rebase this after #3693

@cpcloud
Copy link
Member Author

cpcloud commented May 30, 2013

done.

jreback added a commit that referenced this pull request May 30, 2013
DOC: document read_html and to_html
@jreback jreback merged commit 7413da1 into pandas-dev:master May 30, 2013
@jreback
Copy link
Contributor

jreback commented May 31, 2013

Where you show reading with an attribute, I think you are missing something?

It looks the same as the prvious example

http://pandas.pydata.org/pandas-docs/dev/io.html#io-html

@cpcloud
Copy link
Member Author

cpcloud commented May 31, 2013

where r u looking i don't see the attrs anywhere...also a problem

@cpcloud
Copy link
Member Author

cpcloud commented May 31, 2013

oh i c

@jreback
Copy link
Contributor

jreback commented May 31, 2013

it's missing -u prob copied the prior example

@cpcloud
Copy link
Member Author

cpcloud commented May 31, 2013

man the io docs take 4ever 2 compile

@cpcloud
Copy link
Member Author

cpcloud commented May 31, 2013

there's probably a very tight correlation btwn amt docs amt of tests and amt of code all pairwise

@jreback
Copy link
Contributor

jreback commented May 31, 2013

true!

for 0.11 I had to keep rereading the docs
For all of the indexing chnges
as no tests for language!

@cpcloud
Copy link
Member Author

cpcloud commented May 31, 2013

pr is up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants