-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
DOC: document read_html and to_html #3704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
FYI after #3693 u won't need to import read_html explicitly anymore |
ok i will remove |
i changed a few things around in |
@@ -925,8 +925,106 @@ Reading HTML Content | |||
|
|||
.. versionadded:: 0.11.1 | |||
|
|||
The toplevel :func:`~pandas.io.parsers.read_html` function can accept an HTML | |||
The toplevel :func:`~pandas.io.read_html` function can accept an HTML |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cpcloud this has nothing to do with your PR< but do you know why when you put an inline function reference its not a link? (what should it be?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i changed it to this because it wasn't linking correctly (still not though since pandas.io.__init__
is empty. must've been looking at a different link when i built the docs...). it should link to the api docs. will fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
its not your link, I see this type of thing elsewhere (e.g. in the Stata docs); if you figure it out we prob need to edit in several places
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hm this is annoying
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jreback got it. u must put the exact module reference here so the above should be :func:
~pandas.io.html.read_html``
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still annoying
you might need to rebase this after #3693 |
remove import of read_html
done. |
DOC: document read_html and to_html
Where you show reading with an attribute, I think you are missing something? It looks the same as the prvious example |
where r u looking i don't see the attrs anywhere...also a problem |
oh i c |
it's missing -u prob copied the prior example |
man the io docs take 4ever 2 compile |
there's probably a very tight correlation btwn amt docs amt of tests and amt of code all pairwise |
true! for 0.11 I had to keep rereading the docs |
pr is up |
No description provided.