Skip to content

Call finalize in Series.str #37015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 10, 2020
Merged

Call finalize in Series.str #37015

merged 3 commits into from
Oct 10, 2020

Conversation

TomAugspurger
Copy link
Contributor

xref #28283

@TomAugspurger TomAugspurger added this to the 1.2 milestone Oct 9, 2020
@TomAugspurger TomAugspurger added Strings String extension data type and string data metadata _metadata, .attrs labels Oct 9, 2020
jreback
jreback requested changes Oct 10, 2020
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whatsnew doc note, otherwise lgtm.

@jreback jreback merged commit 58c2150 into pandas-dev:master Oct 10, 2020
@jreback
Copy link
Contributor

jreback commented Oct 10, 2020

thanks

@TomAugspurger TomAugspurger deleted the finalize-str-2 branch October 11, 2020 20:09
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
@TomAugspurger
Call finalize in Series.str (pandas-dev#37015)
dc6b8cb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
metadata _metadata, .attrs Strings String extension data type and string data
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.
2 participants
@TomAugspurger @jreback