TYP: sas, stata, style #36990
Merged
TYP: sas, stata, style #36990
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
reviewed
Oct 8, 2020
pandas/io/sas/sas7bdat.py
Outdated
| @@ -63,11 +64,21 @@ def _convert_datetimes(sas_datetimes: pd.Series, unit: str) -> pd.Series: | |||
|
|
|||
|
|
|||
| class _subheader_pointer: | |||
| pass | |||
| def __init__(self, offset, length, compression, ptype): | |||
There was a problem hiding this comment.
can you defin the types? (alt you can define attributes on the class)
pandas/io/sas/sas7bdat.py
Outdated
| @@ -63,11 +64,21 @@ def _convert_datetimes(sas_datetimes: pd.Series, unit: str) -> pd.Series: | |||
|
|
|||
|
|
|||
| class _subheader_pointer: | |||
There was a problem hiding this comment.
while why are at it, shouldn't these follow pep?
| else: | ||
| buf = path_or_buf | ||
|
|
||
| self._path_or_buf: IO[Any] = buf |
There was a problem hiding this comment.
define as a class attribute?
jreback
requested changes
Oct 10, 2020
| # mypy doesnt like dynamically-defined class | ||
| # error: Variable "cls" is not valid as a type [valid-type] | ||
| # error: Invalid base class "cls" [misc] | ||
| class MyStyler(cls): # type:ignore[valid-type,misc] |
There was a problem hiding this comment.
does this resolve if using an appropriate constructor like: https://docs.python.org/3.7/library/types.html (or the old type constructor)
There was a problem hiding this comment.
i didnt know that types.new_class was a thing. id rather keep the more-idiomatic usage even if mypy doesnt like it
| pass | ||
|
|
||
| class _Column: | ||
| col_id: int |
There was a problem hiding this comment.
could be a dataclass to avoid this repetition
jreback
approved these changes
Oct 10, 2020
|
fair, merge on green-ish |
|
followups appreciated here |
kesmit13
pushed a commit
to kesmit13/pandas
that referenced
this pull request
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff