-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
Fix test_unstack #36987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix test_unstack #36987
Conversation
The test was failing if the ExtensionDtype had an na_value that wasn't equivalent to nan
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @jrm5100 for the PR!
There's still some linting issue (according to CI you need to run black)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I guess it came down to this passing
In [45]: a = pd.Series([1, np.nan], dtype=object)
In [46]: b = pd.Series([1, pd.NA], dtype=object)
In [47]: pd.testing.assert_series_equal(a, b)
FYI, we're making a list of 3rd-party extension types at https://pandas.pydata.org/pandas-docs/stable/ecosystem.html#extension-data-types, if you want to add pandas-genomics to ecosystem.rst
I restarted the failed numpy dev build (timed out) |
thanks @jrm5100 |
shouldn't this raise as these are not equal |
The test was failing if the ExtensionDtype had an na_value that wasn't equivalent to nan
test_unstack
assumes missing values are nan #36986black pandas
git diff upstream/master -u -- "*.py" | flake8 --diff