Skip to content

Fix test_unstack #36987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 8, 2020
Merged

Fix test_unstack #36987

merged 3 commits into from
Oct 8, 2020

Conversation

jrm5100
Copy link
Contributor

@jrm5100 jrm5100 commented Oct 8, 2020

The test was failing if the ExtensionDtype had an na_value that wasn't equivalent to nan

The test was failing if the ExtensionDtype had an na_value that wasn't equivalent to nan
@pep8speaks
Copy link

pep8speaks commented Oct 8, 2020

Hello @jrm5100! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-10-08 19:24:05 UTC

Copy link
Member

@arw2019 arw2019 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @jrm5100 for the PR!

There's still some linting issue (according to CI you need to run black)

Copy link
Contributor

@TomAugspurger TomAugspurger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I guess it came down to this passing

In [45]: a = pd.Series([1, np.nan], dtype=object)

In [46]: b = pd.Series([1, pd.NA], dtype=object)

In [47]: pd.testing.assert_series_equal(a, b)

FYI, we're making a list of 3rd-party extension types at https://pandas.pydata.org/pandas-docs/stable/ecosystem.html#extension-data-types, if you want to add pandas-genomics to ecosystem.rst

@TomAugspurger
Copy link
Contributor

I restarted the failed numpy dev build (timed out)

@jreback jreback added ExtensionArray Extending pandas with custom dtypes or arrays. Testing pandas testing functions or related to the test suite labels Oct 8, 2020
@jreback jreback added this to the 1.2 milestone Oct 8, 2020
@jreback jreback merged commit 344992c into pandas-dev:master Oct 8, 2020
@jreback
Copy link
Contributor

jreback commented Oct 8, 2020

thanks @jrm5100

@jreback
Copy link
Contributor

jreback commented Oct 8, 2020

Thanks, I guess it came down to this passing

In [45]: a = pd.Series([1, np.nan], dtype=object)

In [46]: b = pd.Series([1, pd.NA], dtype=object)

In [47]: pd.testing.assert_series_equal(a, b)

FYI, we're making a list of 3rd-party extension types at https://pandas.pydata.org/pandas-docs/stable/ecosystem.html#extension-data-types, if you want to add pandas-genomics to ecosystem.rst

shouldn't this raise as these are not equal

@TomAugspurger
Copy link
Contributor

shouldn't this raise as these are not equal

I think so. Looks like it's come up in #18463 / #27613

kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ExtensionArray Extending pandas with custom dtypes or arrays. Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: ExtensionArray test_unstack assumes missing values are nan
5 participants