Skip to content

CLN: remove unnecessary BoolBlock.replace #36966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 8, 2020

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

The fastpath it implements is equivalent to the can_hold_element fastpath in Block.replace

@simonjayhawkins simonjayhawkins added Clean Internals Related to non-user accessible pandas implementation labels Oct 8, 2020
@simonjayhawkins simonjayhawkins added this to the 1.2 milestone Oct 8, 2020
@jreback jreback merged commit 7eb6d2f into pandas-dev:master Oct 8, 2020
@jbrockmendel jbrockmendel deleted the ref-bblock branch October 8, 2020 21:23
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Internals Related to non-user accessible pandas implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants