Skip to content

TYP: use OpsMixin for DecimalArray #36961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 10, 2020
Merged

TYP: use OpsMixin for DecimalArray #36961

merged 2 commits into from
Oct 10, 2020

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@simonjayhawkins simonjayhawkins added Refactor Internal refactoring of code Typing type annotations, mypy/pyright type checking labels Oct 8, 2020
@simonjayhawkins simonjayhawkins added this to the 1.2 milestone Oct 8, 2020
@jreback
Copy link
Contributor

jreback commented Oct 8, 2020

i guess should disable this for now

ERROR: /home/runner/work/pandas/pandas/pandas/_libs/tslibs/timezones.pxd Imports are incorrectly sorted and/or formatted.
ERROR: /home/runner/work/pandas/pandas/pandas/_libs/tslibs/offsets.pxd Imports are incorrectly sorted and/or formatted.
ERROR: /home/runner/work/pandas/pandas/pandas/_libs/tslibs/timestamps.pxd Imports are incorrectly sorted and/or formatted.
ERROR: /home/runner/work/pandas/pandas/pandas/_libs/tslibs/ccalendar.pxd Imports are incorrectly sorted and/or formatted.
ERROR: /home/runner/work/pandas/pandas/pandas/_libs/tslibs/conversion.pxd Imports are incorrectly sorted and/or formatted.
ERROR: /home/runner/work/pandas/pandas/pandas/_libs/tslibs/np_datetime.pxd Imports are incorrectly sorted and/or formatted.
ERROR: /home/runner/work/pandas/pandas/pandas/_libs/tslibs/timedeltas.pxd Imports are incorrectly sorted and/or formatted.
ERROR: /home/runner/work/pandas/pandas/pandas/_libs/tslibs/period.pxd Imports are incorrectly sorted and/or formatted.
Check import format using isort DONE

@jbrockmendel
Copy link
Member Author

i guess should disable this for now

I thought i saw a PR that addressed that. if i dont find it ill open one shortly

@jbrockmendel
Copy link
Member Author

yah looks like someone already got to the isort thing, so this is green

@jreback jreback merged commit f47a93c into pandas-dev:master Oct 10, 2020
@jbrockmendel jbrockmendel deleted the scalar-ops-mixin branch October 10, 2020 18:11
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
@jbrockmendel
TYP: use OpsMixin for DecimalArray (pandas-dev#36961)
ee65738
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Refactor Internal refactoring of code Typing type annotations, mypy/pyright type checking
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.
3 participants
@jbrockmendel @jreback @simonjayhawkins