REGR: Allow positional arguments in DataFrame.agg #36950
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vorhersager
pushed a commit
to google/madi
that referenced
this pull request
Oct 7, 2020
…andas#36948 and PR: pandas-dev/pandas#36950. Also makes the set_axis call before plotting the gradient series deliberately in place. PiperOrigin-RevId: 335933611
vorhersager
pushed a commit
to google/madi
that referenced
this pull request
Oct 7, 2020
…andas#36948 and PR: pandas-dev/pandas#36950. Also makes the set_axis call before plotting the gradient series deliberately in place. PiperOrigin-RevId: 335933611
jreback
added
Apply
|
seems reasonable; the ci / checks are failing. |
Although `DataFrame.agg` is documented as accepting `func, axis, *args, **kwargs` with `*args` and `**kwargs` passed to `func`, passing positional arguments raises a TypeError. The reason for this is that the internal call to `self._aggregate` uses a keyword argument (axis) before passing *args and `**kwargs`, and as such the first positional argument is always interpreted as a second specification of `axis`, which raises TypeError. Prior to commit 433c900, TypeErrors were being suppressed, falling back to `self.apply`, which in v1.1.0 turned into an error. This fixes issue pandas-devGH-36948.
|
The failures look unrelated. I've rebased against the current master and I think #36978 might have been the cause of the check failure. |
|
@pganssle Conflict needs resolved. |
|
Thanks @pganssle |
|
@meeseeksdev backport 1.1.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Oct 9, 2020
simonjayhawkins
pushed a commit
that referenced
this pull request
Oct 9, 2020
…#37005) Co-authored-by: Paul Ganssle <[email protected]>
kesmit13
pushed a commit
to kesmit13/pandas
that referenced
this pull request
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although
DataFrame.aggis documented as acceptingfunc, axis, *args, **kwargswith*argsand**kwargspassed tofunc, passing positional arguments raises a TypeError.The reason for this is that the internal call to
self._aggregateuses a keyword argument (axis) before passing *args and**kwargs, and as such the first positional argument is always interpreted as a second specification ofaxis, which raises TypeError.Prior to commit 433c900, TypeErrors were being suppressed, falling back to
self.apply, which in v1.1.0 turned into an error.This fixes issue GH-36948.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff