Skip to content

REGR: Make DateOffset immutable #36946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 8, 2020
Merged

REGR: Make DateOffset immutable #36946

merged 1 commit into from
Oct 8, 2020

Conversation

dsaxton
Copy link
Member

@dsaxton dsaxton commented Oct 7, 2020

I'm assuming this is a regression and not behavior we want?

@dsaxton dsaxton added Datetime Datetime data dtype Regression Functionality that used to work in a prior pandas version labels Oct 7, 2020
@dsaxton dsaxton added this to the 1.1.4 milestone Oct 7, 2020
@dsaxton dsaxton requested a review from jbrockmendel October 7, 2020 17:11
@jbrockmendel
Copy link
Member

LGTM

@jreback jreback added the Frequency DateOffsets label Oct 8, 2020
@jreback jreback merged commit 41ec93a into pandas-dev:master Oct 8, 2020
@jreback
Copy link
Contributor

jreback commented Oct 8, 2020

thanks @dsaxton

any ideas about the windows failures ? (obviously not related here)

@dsaxton
Copy link
Member Author

dsaxton commented Oct 8, 2020

any ideas about the windows failures ? (obviously not related here)

Hmm, I'm not sure to be honest

@dsaxton dsaxton deleted the immutable-dateoffset branch October 8, 2020 22:22
simonjayhawkins pushed a commit that referenced this pull request Oct 9, 2020
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Datetime Datetime data dtype Frequency DateOffsets Regression Functionality that used to work in a prior pandas version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

REGR: DateOffset attributes update fails with no errors.
3 participants