REF/TYP: define methods non-dynamically for SparseArray #36943
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pandas/core/arrays/sparse/array.py
Outdated
| fill_value = op(self.fill_value, other) | ||
| result = op(self.sp_values, other) | ||
| @unpack_zerodim_and_defer("__and__") | ||
| def __and__(self, other) -> "SparseArray": |
There was a problem hiding this comment.
with #36964 merged, can these now be removed?
pandas/core/arrays/sparse/array.py
Outdated
| return compat.set_function_name(cmp_method, name, cls) | ||
| @unpack_zerodim_and_defer("__xor__") | ||
| def __xor__(self, other) -> "SparseArray": | ||
| return self._logical_method(other, operator.xor) |
There was a problem hiding this comment.
this was using _create_arithmetic_method b4 whereas and and or were using _create_comparison_method. Any user facing changes?
| @@ -796,7 +795,6 @@ def __getitem__(self, key): | |||
| key = check_array_indexer(self, key) | |||
|
|
|||
| if com.is_bool_indexer(key): | |||
| key = check_bool_indexer(self, key) | |||
simonjayhawkins
added
Refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff