DOC: Update dependency for to_markdown documentation #36938
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding to the documentation that tabulate is required for to_markdown to be executed
|
Thanks @eyaltrabelsi , but we already raise an import error if , does this need to be added to the docstring? |
|
@MarcoGorelli In my opinion it should be part of the documentation as well, but if you think its unneeded we can close this PR :) |
jreback
added
Dependencies
jreback
requested changes
Oct 10, 2020
pandas/core/series.py
Outdated
| @@ -1471,6 +1471,10 @@ def to_markdown( | |||
| str | |||
| {klass} in Markdown-friendly format. | |||
|
|
|||
| Notes | |||
| ----- | |||
| This method requires the tabulate package. | |||
There was a problem hiding this comment.
Perhaps link to it as well, while we're here?
There was a problem hiding this comment.
@MarcoGorelli thanks for feedback, I have added the link
Co-authored-by: Marco Gorelli <[email protected]>
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Oct 26, 2020
* Update to_markdown documentation Adding to the documentation that tabulate is required for to_markdown to be executed * Move the optional dependency to a note * Update series.py * Update series.py * Update pandas/core/series.py Co-authored-by: Marco Gorelli <[email protected]> Co-authored-by: Marco Gorelli <[email protected]>
kesmit13
pushed a commit
to kesmit13/pandas
that referenced
this pull request
Nov 2, 2020
* Update to_markdown documentation Adding to the documentation that tabulate is required for to_markdown to be executed * Move the optional dependency to a note * Update series.py * Update series.py * Update pandas/core/series.py Co-authored-by: Marco Gorelli <[email protected]> Co-authored-by: Marco Gorelli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding to the documentation that tabulate is required for to_markdown to be executed
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff