Skip to content

TYP: clean unreachable code and duplicate test #27396 #36935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 10, 2020
Merged

TYP: clean unreachable code and duplicate test #27396 #36935

merged 1 commit into from
Oct 10, 2020

Conversation

fangchenli
Copy link
Member

@fangchenli fangchenli commented Oct 7, 2020 •
edited
Loading

xref #27396

pandas/tests/frame/test_to_csv.py:363: error: Right operand of 'or' is never evaluated  [unreachable]
pandas/tests/frame/test_to_csv.py:389: error: Right operand of 'or' is never evaluated  [unreachable]
pandas/tests/frame/test_to_csv.py:417: error: Right operand of 'or' is never evaluated  [unreachable]
pandas/tests/frame/test_to_csv.py:443: error: Right operand of 'or' is never evaluated  [unreachable]

@jreback jreback added IO CSV read_csv, to_csv Testing pandas testing functions or related to the test suite labels Oct 10, 2020
@jreback jreback added this to the 1.2 milestone Oct 10, 2020
@jreback jreback merged commit 701d61b into pandas-dev:master Oct 10, 2020
@jreback
Copy link
Contributor

jreback commented Oct 10, 2020

thanks @fangchenli

kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
@fangchenli
TYP: clean unreachable code and duplicate test pandas-dev#27396 (pand…
deb10ac 
…as-dev#36935)
@fangchenli fangchenli deleted the unreachable-csv branch November 18, 2022 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
IO CSV read_csv, to_csv Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.
2 participants
@fangchenli @jreback