BUG: Fixed IntegerArray.__array_ufunc__ with nout #36913
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomAugspurger
force-pushed
the
integer-array-ufunc-binary-out
branch
from
8fd238f to
d3f63c1
Compare
We forgot to return.
jbrockmendel
reviewed
Oct 6, 2020
| @@ -64,6 +64,20 @@ def test_ufuncs_binary_int(ufunc): | |||
| tm.assert_extension_array_equal(result, expected) | |||
|
|
|||
|
|
|||
| def test_ufunc_binary_output(): | |||
| a = integer_array([1, 2, np.nan]) | |||
| result = np.modf(a) | |||
There was a problem hiding this comment.
could parametrize over the (few?) functions that could go through here?
There was a problem hiding this comment.
The binary ufuncs that overlap with dunder methods hit a different code path. I'm not sure of others (and I'm also not sure I see the value in parametrizing over them. Given the current structure of the code they should be redundant).
jbrockmendel
approved these changes
Oct 6, 2020
|
thanks @TomAugspurger |
kesmit13
pushed a commit
to kesmit13/pandas
that referenced
this pull request
Nov 2, 2020
We forgot to return.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We forgot to return.