BUG: RollingGroupby not respecting sort=False #36911
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Oct 6, 2020
added 5 commits
October 6, 2020 18:05
jreback
requested changes
Oct 8, 2020
pandas/core/groupby/grouper.py
Outdated
| # GH 36889 | ||
| indices_dict = {} | ||
| codes, uniques = algorithms.factorize(self.grouper, sort=self.sort) | ||
| for i, category in enumerate(Index(uniques)): |
There was a problem hiding this comment.
can you do a dict-comprehension
remove the issue comment, but instead add a comment on what we are doing here
jreback
approved these changes
Oct 8, 2020
|
lgtm merge on green. |
|
@meeseeksdev backport 1.1.x |
simonjayhawkins
pushed a commit
to simonjayhawkins/pandas
that referenced
this pull request
Oct 9, 2020
…=False Co-authored-by: Matt Roeschke <[email protected]>
simonjayhawkins
added a commit
that referenced
this pull request
Oct 9, 2020
…7002) Co-authored-by: Matthew Roeschke <[email protected]> Co-authored-by: Matt Roeschke <[email protected]>
kesmit13
pushed a commit
to kesmit13/pandas
that referenced
this pull request
Nov 2, 2020
* BUG: RollingGroupby not respecting sort * move to 1.1.4 * Just use factorize * Add comments and turn into dict comprenehsion Co-authored-by: Matt Roeschke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff