Skip to content

REF: separate flex from non-flex DataFrame ops #36843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 10, 2020

Conversation

jbrockmendel
Copy link
Member

@jbrockmendel jbrockmendel commented Oct 3, 2020

Unless supporting this is intentional, in which case we should deprecate and explicitly implement flex-bool operations.

If/when this is done, we can stop passing special and even cls.

@jreback jreback added Numeric Operations Arithmetic, Comparison, and Logical operations Refactor Internal refactoring of code labels Oct 7, 2020
@jreback jreback added this to the 1.2 milestone Oct 7, 2020
@jreback
Copy link
Contributor

jreback commented Oct 7, 2020

i guess technicaly this is an api change, so add a note.

cc @TomAugspurger if any comments.

@TomAugspurger
Copy link
Contributor

I'm not sure what a "flex" method is. What's the user-facing change here?

@jbrockmendel
Copy link
Member Author

"flex" methods are all the non-dunder arith/cmp ops: add, sub, eq, ne, ...

The user facing change is that frame.__and__(other, axis=0, fill_value= ...), or other dunder methods non-idiomatically accepting kwargs. The potential trouble is that for &|^, there are no non-dunder versions with the kwarg support.

@jreback
Copy link
Contributor

jreback commented Oct 7, 2020

can you rebase

@TomAugspurger
Copy link
Contributor

The user facing change is that frame.and(other, axis=0, fill_value= ...), or other dunder methods non-idiomatically accepting kwargs.

So this would break explicitly calling frame.__and__(other, axis=0)? I'm fine with that. I'm fine with not calling that a breaking change since dunder methods should be called by using the operators or the operator module.

@jbrockmendel
Copy link
Member Author

whatsnew added, green-as-it-gets

@jreback jreback merged commit 7f1c3b1 into pandas-dev:master Oct 10, 2020
@jreback
Copy link
Contributor

jreback commented Oct 10, 2020

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Numeric Operations Arithmetic, Comparison, and Logical operations Refactor Internal refactoring of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API: disallow frame.__and__(other, axis="foo", fill_value="bar") etc
3 participants